Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform to 21 #973

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Platform to 21 #973

merged 3 commits into from
Oct 13, 2023

Conversation

micronaut-build
Copy link
Contributor

Update common files

@micronaut-build micronaut-build added the relates-to: build label for issues related to the build file or CI label Oct 13, 2023
@sdelamo
Copy link
Contributor

sdelamo commented Oct 13, 2023

We get

buildSrc:compileKotlin'.

Unknown Kotlin JVM target: 21

@timyates what should we do?

@sdelamo sdelamo changed the title [platform] Update common files for branch 4.2.x Platform to 21 Oct 13, 2023
@timyates timyates requested a review from melix October 13, 2023 08:20
@timyates
Copy link
Contributor

Kotlin doesn't support Java 21 yet... so we have to downgrade the JVM target

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sdelamo
Copy link
Contributor

sdelamo commented Oct 13, 2023

is this because it is a buildSrc/build.gradle.kts?

@sdelamo sdelamo merged commit 93182ba into 4.2.x Oct 13, 2023
11 checks passed
@sdelamo sdelamo deleted the sync-files-4.2.x branch October 13, 2023 09:14
@sdelamo
Copy link
Contributor

sdelamo commented Oct 13, 2023

@wetted you may need to apply a similar fix in other modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melix melix melix approved these changes

Assignees
No one assigned
Labels
relates-to: build label for issues related to the build file or CI
Projects
4.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micronaut-build @sdelamo @timyates @melix